Fix related name when deleting filter group in alert profiles #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.7.x #2729 +/- ##
==========================================
+ Coverage 55.19% 55.38% +0.18%
==========================================
Files 561 567 +6
Lines 40917 41052 +135
==========================================
+ Hits 22586 22738 +152
+ Misses 18331 18314 -17 ☔ View full report in Codecov by Sentry. |
lunkwill42
previously approved these changes
Nov 14, 2023
johannaengland
force-pushed
the
bugfix/related-names-alert-profile
branch
from
9790db8 to
804a40d
Compare
johannaengland
dismissed
lunkwill42’s stale review
The base branch was changed.
|
Kudos, SonarCloud Quality Gate passed!
|
hmpf
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another thing I overlooked in #2544...